Show diff#23
Open
yaroslav8765 wants to merge 10 commits intoshow-verify-auto-difffrom
Open
Conversation
ivictbor
requested changes
Apr 28, 2026
| } | ||
|
|
||
| if (!(sessionsIds) || !confirmationResult) { | ||
| resolveAllIdsAsFailed('Confirmation window was closed or did not return required data'); |
Contributor
There was a problem hiding this comment.
@yaroslav8765 after this code goes to bottom and creates a some not super clear because code still goes to resolveResponse? Second attempt might be no op but still very dangerous if soemthing else will pass it.
Please for all resolves as failed return from function at all
return resolveAllIdsAsFailed('Confirmation window was closed or did no
all resolveAllIdsAsFailed should stop execution of function
…UI and functionality - Updated TOTP modal layout with a close button and enhanced styling. - Improved passkey settings layout with better card design and action buttons. - Refactored passkey management functions for clarity and efficiency. - Added error handling for verification responses in the main plugin.
…anslations-in-2fa-plug fix: update error messages and translations in 2FA components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.